Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Contribution notification displays 'undefined' instead of 'BAT' #14417

Closed
LaurenWags opened this issue Jun 14, 2018 · 1 comment
Closed

Contribution notification displays 'undefined' instead of 'BAT' #14417

LaurenWags opened this issue Jun 14, 2018 · 1 comment

Comments

@LaurenWags
Copy link
Member

Description

After using 0.23.8 to perform a ledger contribution, the notification banner says 'Your contribution of 10 undefined has been processed'. This should say BAT instead of undefined.

Steps to Reproduce

  1. Launch Brave with LEDGER_ENVIRONMENT=staging and a clean profile on 0.23.8
  2. Enable Payments
  3. Add some sites to the ledger table
  4. Add BAT to your staging wallet
  5. Close Brave.
  6. Adjust reconcile stamp in ledger-state.json file to be yesterday.
  7. Launch Brave with LEDGER_ENVIRONMENT=staging LEDGER_VERBOSE=true LEDGER_NO_DELAY=true and LEDGER_NO_FUZZING=true if you do not have 30 minutes of browsing time.
  8. Wait for contribution to go through.

Actual result:
Notification banner displays 'undefined'
screen shot 2018-06-14 at 3 43 02 pm

Expected result:
Notification banner should display BAT as it does in 0.22.810
screen shot 2018-06-14 at 4 05 43 pm

Reproduces how often:
Easily

Brave Version

about:brave info:
0.23.8

Reproducible on current live release:
no, this does not reproduce on 0.22.810 using staging

Additional Information

Found by @GeetaSarvadnya on Windows. Reproduced on macOS.

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 25, 2018

Verified on Windows 10 x64

  • 0.23.16 2042c45
  • Muon 7.1.1
  • libchromiumcontent: 67.0.3396.87

Verified on Ubuntu 18.04 x64 using the following build:

  • 0.23.16 2042c45
  • muon: 7.1.1
  • libchromiumcontent: 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.17 bc754eb
  • Muon 7.1.2
  • libchromiumcontent 67.0.3396.87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.