This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixing undefined currency value for contribution notification #14425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14417
Basically the transaction keys were swapped, trying to access the
currency
prop first as opposed tofiat
. Contribution map is structured like so:{ "fiat": Map { "amount": 10, "currency": "BAT" }, "rates": Map { "EUR": 0.16415440004057, "USD": 0.19355117, "BCH": 0.00022834810733109726, "BTC": 0.0000327, "DASH": 0.0007821603506058262, "BTG": 0.005958015042318794, "XRP": 0.36440067259188086, "ETH": 0.0004051167013833253, "LTC": 0.0020486297689414294 }, "satoshis": undefined, "altcurrency": "BAT", "probi": "10000000000000000000", "fee": undefined }
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Defined in #14417
Reviewer Checklist:
Tests