Use API: app.dock.downloadFinished(filePath) #1667

bbondy · 2016-05-11T01:42:52Z

Test plan

Should be added in next release after 0.37.8
electron/electron#5477

cndouglas · 2017-04-21T05:44:34Z

Q/A steps:

Navigate to https://brave.com/ .
Click Get Brave and then click Save.
As the download progress bar approaches 100%, look at the Downloads folder dock icon.
Make sure the dock icon "bounces" when the download finishes.

alexwykoff · 2017-05-24T17:28:32Z

Not seeing dock bounce in 0.15.307, was this reverted?

bbondy changed the title ~~Add API: app.dock.downloadFinished(filePath)~~ Use API: app.dock.downloadFinished(filePath) May 11, 2016

cezaraugusto added the enhancement label Jun 20, 2016

cndouglas added OS/macOS shell-integration Integrating brave with OS-level UI features. labels Dec 9, 2016

cndouglas mentioned this issue Jan 11, 2017

No download complete notification when download bar is closed #2658

Closed

luixxiul added this to the Backlog milestone Jan 11, 2017

cndouglas self-assigned this Apr 21, 2017

cndouglas mentioned this issue Apr 21, 2017

Implement app.dock.downloadFinished #8418

Merged

4 tasks

cndouglas modified the milestones: 0.15.1, Backlog Apr 21, 2017

cndouglas added the QA/test-plan-specified label Apr 21, 2017

bbondy closed this as completed in #8418 Apr 26, 2017

luixxiul added the release-notes/include label Apr 26, 2017

This was referenced May 25, 2017

0.15.3xx OS X RC pass #9035

Closed

0.15.3xx Windows x64 RC run #9036

Closed

0.15.3xx Linux RC run #9037

Closed

alexwykoff added QA/checked-macOS QA/checked-Linux QA/checked-Win32 QA/checked-Win64 labels May 25, 2017