Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Implement app.dock.downloadFinished #8418

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Implement app.dock.downloadFinished #8418

merged 1 commit into from
Apr 26, 2017

Conversation

cndouglas
Copy link

Make the Downloads folder dock icon "bounce" when a download is complete (macOS-only).

Resolves #1667

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. Navigate to https://brave.com/ .
  2. Click Get Brave and then click Save.
  3. As the download progress bar approaches 100%, look at the Downloads folder dock icon.
  4. Make sure the dock icon "bounces" when the download finishes.

Make the Downloads folder dock icon "bounce" when a download is complete (macOS-only).

Resolves #1667
@cndouglas cndouglas added this to the 0.15.1 milestone Apr 21, 2017
@cndouglas cndouglas self-assigned this Apr 21, 2017
@cndouglas
Copy link
Author

Question: should the code be placed in electronDownloadItem.js or app/filtering.js?

@bbondy
Copy link
Member

bbondy commented Apr 26, 2017

It's good there. Thanks, works great.

@bbondy bbondy merged commit 4af63f4 into brave:master Apr 26, 2017
@cndouglas cndouglas deleted the dock-download-finished branch April 26, 2017 04:52
@alexwykoff
Copy link
Contributor

I wasn't able to replicate in 0.15.307, did this get reverted?

@luixxiul
Copy link
Contributor

d3ff9d9

@luixxiul
Copy link
Contributor

so it seems like it's not.

@cndouglas
Copy link
Author

It's working for me with the latest master (6a9a017).

@cndouglas
Copy link
Author

Also works for me with 0.15.307 on macOS 10.12.x.

@alexwykoff
Copy link
Contributor

we're currently building 0.15.3xx releases off of dev-channel, so master may be ahead 😄

@cndouglas
Copy link
Author

@alexwykoff Good to know. I can confirm this feature is working with the version just released (0.15.310, 6b5e4e2).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
OS/macOS shell-integration Integrating brave with OS-level UI features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants