Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autofill should not happen on URL bar unless item in autocomplete list is clicked #3012

Closed
luixxiul opened this issue Aug 6, 2016 · 1 comment

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 6, 2016

From support:

When I try to paste a hyperlink or type something in I need to ensure the cursor is far away from the drop-down history in the URL address bar, otherwise it auto-fills with one of those links and then starts appending what I'm typing onto it. The auto-fill shouldn't happen unless I click on the hyperlink from the history when the drop down box appears.

Sometimes I notice this too.

@bbondy bbondy added this to the 0.11.4dev milestone Aug 7, 2016
@willy-b
Copy link
Contributor

willy-b commented Aug 9, 2016

I pushed a commit to my fork that makes sure that mousing over URL autocomplete suggestions does not disrupt the URL you are typing (it now only updates the highlighted suffix after your cursor).

However, I am having a strange issue where clicking autocomplete suggestions after the first one occasionally updates the URL bar but does not close the autocomplete suggestions dropdown and does not load the new URL. Frustratingly, it is intermittent.

Somehow the mouseover handler generated by navigateClickHandler in UrlBarSuggestions#getNewSuggestionList is not always being invoked. Anyway, a commit shows up as associated with this issue but there won't be a PR from me until I fix this other problem (hopefully shortly).

@bbondy bbondy modified the milestones: 0.11.4dev, 0.11.5dev Aug 9, 2016
@bbondy bbondy modified the milestones: 0.11.6dev, 0.11.5dev Aug 13, 2016
bbondy added a commit that referenced this issue Aug 18, 2016
 URL bar autocomplete mouseover does not interfere with typed URL (fixes #3012) (take 2)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants