Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

ledger needs tests #3249

Closed
diracdeltas opened this issue Aug 18, 2016 · 4 comments
Closed

ledger needs tests #3249

diracdeltas opened this issue Aug 18, 2016 · 4 comments
Labels
automated-tests feature/rewards

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Aug 18, 2016 •
edited
Loading

@mrose17 please add tests for app/ledger.js; i or someone else can add the ones for the prefs panel
@diracdeltas diracdeltas added this to the 1.0.0 milestone Aug 18, 2016
@diracdeltas diracdeltas mentioned this issue Aug 18, 2016
Merged
This was referenced Aug 30, 2016
Open
Open
@mrose17
Copy link
Member

mrose17 commented Aug 30, 2016

@diracdeltas - sadly, there's more code that has to be written for the ledger, per se, and its backend, and that has to come first...

@diracdeltas
Copy link
Member Author

@mrose17 yup, i figured. but better to have something in for 1.0 even if test coverage is < 100%

@mrose17
Copy link
Member

mrose17 commented Aug 30, 2016

indeed!

diracdeltas added a commit that referenced this issue Sep 1, 2016
@diracdeltas
Start adding tests for payments panel
980e664 
address #3249

Auditors: @bbondy
@luixxiul luixxiul added the tests label Sep 18, 2016
@mrose17 mrose17 modified the milestones: 1.1.0, 1.0.0 Oct 22, 2016
@luixxiul luixxiul modified the milestones: 0.13.1, 1.1.0 Jan 21, 2017
@bbondy bbondy modified the milestones: 0.13.2, 0.13.1 Jan 28, 2017
@mrose17
Copy link
Member

mrose17 commented Jan 31, 2017

OBE by #6890 and #6911

@mrose17 mrose17 closed this as completed Jan 31, 2017
@luixxiul luixxiul removed this from the 0.13.3 milestone Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
automated-tests feature/rewards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrose17 @diracdeltas @bbondy @luixxiul