This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Give more meaningful name to siteUtils method #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param sites The application state's Immutable sites list. | ||
| */ | ||
| module.exports.clearSitesWithoutTags = function (sites) { | ||
| module.exports.clearHistory = function (sites) { |
There was a problem hiding this comment.
if this clears history for all sites we should use the method here https://github.com/brave/browser-laptop/blob/master/app/sessionStore.js#L258
|
can you squash and then I think this is good to merge |
clearSitesWithoutTags => clearHistory Fixes #3639 Auditors: @bbondy Test Plan: - Visit about:history - Use the "Clear browsing data button" - Ensure "Browsing history" is on and click "OK" - Go back to about:history - Verify history is cleared 2) Updated sessionStore.cleanAppData to use siteUtil.clearHistory NOTE: Conversion to Immutable happens because siteUtil assumes all input is Immutable. appState is already converted to a regular JS object when it reaches cleanAppData. Auditors: @bridiver Test Plan: - Ensure history is set to clear on exit - Open a few sites - Exit Brave - Launch Brave and verify sites are removed
|
@bridiver squashed 😄 |
|
nice cleanup, thanks. |
This was referenced Sep 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.clearSitesWithoutTags => clearHistory
Fixes #3639
Auditors: @bbondy @bridiver
Test Plan: