Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Give more meaningful name to siteUtils method #3640

Merged
merged 1 commit into from
Sep 3, 2016
Merged

Give more meaningful name to siteUtils method #3640

merged 1 commit into from
Sep 3, 2016

Commits on Sep 2, 2016

  1. 1) Give more meaningful name to siteUtils method:

    clearSitesWithoutTags => clearHistory
    
    Fixes #3639
    
    Auditors: @bbondy
    
    Test Plan:
    - Visit about:history
    - Use the "Clear browsing data button"
    - Ensure "Browsing history" is on and click "OK"
    - Go back to about:history
    - Verify history is cleared
    
    2) Updated sessionStore.cleanAppData to use siteUtil.clearHistory
    
    NOTE: Conversion to Immutable happens because siteUtil assumes all input is Immutable.
    appState is already converted to a regular JS object when it reaches cleanAppData.
    
    Auditors: @bridiver
    
    Test Plan:
    - Ensure history is set to clear on exit
    - Open a few sites
    - Exit Brave
    - Launch Brave and verify sites are removed
    bsclifton committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    5e6f195 View commit details
    Browse the repository at this point in the history