Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make all properties files translatable #3947

Closed
luixxiul opened this issue Sep 13, 2016 · 5 comments
Closed

Make all properties files translatable #3947

luixxiul opened this issue Sep 13, 2016 · 5 comments
Labels
l10n QA/no-qa-needed
Milestone
0.12.1dev

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: Several .properties files cannot be translated.

https://github.com/brave/browser-laptop/blob/master/app/extensions/brave/locales/ja-JP/autofill.properties
https://github.com/brave/browser-laptop/blob/master/app/extensions/brave/locales/ja-JP/errorMessages.properties
https://github.com/brave/browser-laptop/blob/master/app/extensions/brave/locales/ja-JP/history.properties
@luixxiul luixxiul added the l10n label Sep 13, 2016
@luixxiul
Copy link
Contributor Author

I think they are not set up for translation on transifex.com

@bbondy
Copy link
Member

bbondy commented Sep 13, 2016

hah I just added those yesterday before you posted this. I will pull new translations now, and they should appear now.

@bbondy bbondy closed this as completed Sep 13, 2016
bbondy added a commit that referenced this issue Sep 13, 2016
@bbondy
Update l10n
9bafcc2 
Auditors: @luixxiul

Fix #3947

Test Plan: Suguru will verify
@luixxiul
Copy link
Contributor Author

Confirmed on transifex.com too, thanks :-)

@luixxiul
Copy link
Contributor Author

Some strings are duping, eg: app.properties#L188 and autofill.properties#L11. We will need to organize them to avoid confusion.

@luixxiul luixxiul mentioned this issue Sep 13, 2016
Closed
@bbondy
Copy link
Member

bbondy commented Sep 13, 2016

file issues I think when they come up, or work on one issue and put several of them in there in chunks.

@luixxiul luixxiul added this to the 0.12.1dev milestone Sep 15, 2016
@alexwykoff alexwykoff mentioned this issue Sep 15, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
l10n QA/no-qa-needed
Projects
None yet
Milestone
0.12.1dev
Development

No branches or pull requests
2 participants
@bbondy @luixxiul