You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Issue (🎁):
When Payments is enabled and a user wallet active, Brave queries a Bitcoin API for the wallet balance every minute.
This could be undesirable because APIs might know when browser users are online.
It is also additional load, and if we run our own blockchain API it could be intense.
Expected (📦):
Query balance only when necessary:
Payments pane is open
After reconciliation when balance drops below next reconciliation amount (? something like this)
Platform (Win7, 8, 10? macOS? Linux distro?):
all
Brave Version:
0.12.1
Steps to reproduce:
1. In ledger.js line ~1062 add logging to ledgerBalance.getBalance
2. Enable Payments and ensure a user wallet exists
3. Log output shows periodic function calls
@ayumi , if you run with the env variable LEDGER_VERBOSE set to true (LEDGER_VERBOSE=true npm start) @mrose17 has extensive logging in place (as he is alluding to, I think).
Issue (🎁):
When Payments is enabled and a user wallet active, Brave queries a Bitcoin API for the wallet balance every minute.
This could be undesirable because APIs might know when browser users are online.
It is also additional load, and if we run our own blockchain API it could be intense.
Expected (📦):
Query balance only when necessary:
Platform (Win7, 8, 10? macOS? Linux distro?):
all
Brave Version:
0.12.1
Steps to reproduce:
1. In
ledger.js
line ~1062 add logging toledgerBalance.getBalance
2. Enable Payments and ensure a user wallet exists
3. Log output shows periodic function calls
cc @bridiver @diracdeltas @mrose17
The text was updated successfully, but these errors were encountered: