Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

While in fullscreen the navbar is not visible #4234

Closed
Sh1d0w opened this issue Sep 23, 2016 · 2 comments
Closed

While in fullscreen the navbar is not visible #4234

Sh1d0w opened this issue Sep 23, 2016 · 2 comments
Assignees

Comments

@Sh1d0w
Copy link

Sh1d0w commented Sep 23, 2016

As discussed with @bbondy currently on Windows and Linux, while in fullscreen (F11) the navbar is not visible. This makes opening a new page or switching to a new tab a pain, because you have to go out of fullscreen, switch and then go fullscreen again.

How chrome and FF work in that case:

http://webm.land/media/fVzp.webm

I have made PR which replicates exact behaviour but @bbondy wasn't happy how it was working on Mac.

@bradleyrichter Can you please advice how you see this working on different platforms, so I can amend my PR? What do you think will be the best in term of UX?

Thanks

@Sh1d0w Sh1d0w added this to the 0.12.3dev milestone Sep 23, 2016
@bradleyrichter
Copy link
Contributor

@Sh1d0w I do think the nav bars should be visible on all platforms for full screen mode. The exception is for full-screen video playing where NO nav bars should be shown.

If you fix changed mac, then can you try to exclude mac from the change?

@Sh1d0w
Copy link
Author

Sh1d0w commented Sep 23, 2016

Yes Brad already did that. Can you please discuss this with Brian and you
can also test my PR which is ready now.

Sent from my smartphone. Please excuse any typos.

On Sep 23, 2016 19:40, "Brad Richter" notifications@github.com wrote:

@Sh1d0w https://github.com/Sh1d0w I do think the nav bars should be
visible on all platforms for full screen mode. The exception is for
full-screen video playing where NO nav bars should be shown.

If you fix changed mac, then can you try to exclude mac from the change?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4234 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE1v5W5yxsLO815z-qopCgnG6zm9McEdks5qtAEYgaJpZM4KE6n8
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants