Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Caption buttons are not shown when in fullscreen mode (Windows) #4376

Closed
bsclifton opened this issue Sep 29, 2016 · 1 comment
Closed

Caption buttons are not shown when in fullscreen mode (Windows) #4376

bsclifton opened this issue Sep 29, 2016 · 1 comment

Comments

@bsclifton
Copy link
Member

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Introduced with #3854, I had hidden the caption buttons based on verbal feedback from folks.

Expected behavior:
Caption buttons should always show when fullscreen (else, there is not an easy way to exit)

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All Windows
  • Brave Version:
    0.12.2 and newer
  • Steps to reproduce:
    1. Launch Brave
    2. Hit F11 to go full screen
    3. Notice you can't exit (no caption buttons)
  • Screenshot if needed:
  • Any related issues:
bbondy pushed a commit that referenced this issue Sep 29, 2016
Fixes #4376

Auditor: @bbondy

Test plan:
1. Launch Brave
2. Go full screen by pushing F11
3. Notice the caption buttons are showing
4. Use the caption buttons to exit
@luixxiul
Copy link
Contributor

luixxiul commented Oct 1, 2016

I thought the max button would exit the fullscreen mode (min and exit buttons work). Should it not so?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants