Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Search via URL bar doesn't work when ending with a dot #4546

Closed
JamborJan opened this issue Oct 5, 2016 · 0 comments · Fixed by #4557
Closed

Search via URL bar doesn't work when ending with a dot #4546

JamborJan opened this issue Oct 5, 2016 · 0 comments · Fixed by #4557
Assignees
@darkdh
Labels
feature/search QA/checked-Linux QA/checked-macOS QA/checked-Win64
Milestone
0.12.4dev

Comments

@JamborJan
Copy link

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When I'm using the URL bar to search for something and I or auto correct adds a dot at the end brave thinks it's a URL and wants to open this wrong URL

Expected behavior:
Brave should trigger the configured search engine to search for the term including the dot.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    tested with iOS 10.0.2 and OS X 10.11.6 with Safari 10.0
  • Brave Version:
    0.12.3
  • Steps to reproduce:
    1. type "test." in the empty URL bar
    2. hit enter
    3. Brave tries to open "http://test./"
  • Screenshot if needed:
    bildschirmfoto 2016-10-05 um 14 30 37
  • Any related issues:
@darkdh darkdh self-assigned this Oct 5, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 5, 2016
@darkdh
Add search query conditions
dddd976 
fix brave#4546

Auditors: @bsclifton

Test Plan:
1. Type ".brave" on url bar and there should be a search result page of ".brave"
2. Type "brave." on url bar and there should be a search result page of "brave."
@darkdh darkdh mentioned this issue Oct 5, 2016
Merged
4 tasks
@darkdh darkdh added this to the 0.12.4dev milestone Oct 5, 2016
This was referenced Oct 6, 2016
Closed
Closed
Closed
Closed
This was referenced Oct 7, 2016
Closed
Closed
Closed
Closed
@bsclifton bsclifton mentioned this issue Dec 8, 2016
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/search QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.4dev
Development

Successfully merging a pull request may close this issue.

Add search query conditions darkdh/browser-laptop
6 participants
@aekeus @alexwykoff @luixxiul @JamborJan @darkdh @srirambv