Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

adblock list blocks other elements than ads too #4633

Closed
luixxiul opened this issue Oct 8, 2016 · 2 comments
Closed

adblock list blocks other elements than ads too #4633

luixxiul opened this issue Oct 8, 2016 · 2 comments
Assignees
@bbondy
Labels
feature/adblock QA/checked-macOS QA/checked-Win32
Milestone
0.12.5dev

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 8, 2016

Describe the issue you encountered: adblock list blocks other elements than ads too.

Expected behavior: It should block ads only.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.4
  • Steps to reproduce:
    1. Open https://www.yahoo.co.jp in a new tab
    2. Open about:adblock
    3. Enable "ABP Japanese filters"
    4. Open https://www.yahoo.co.jp in another new tab
  • Screenshot if needed:

clipboard01

  • Any related issues:

I confirmed the adfilter list worked properly with adblock plus on Chrome. You can confirm it by yourself, subscribing https://raw.githubusercontent.com/k2jp/abp-japanese-filters/master/abpjf.txt
@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 8, 2016

cc @bbondy

@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 8, 2016

Setting a milestone for now as the issue can be global

@luixxiul luixxiul added this to the 0.12.5dev milestone Oct 8, 2016
@bbondy bbondy self-assigned this Oct 8, 2016
@bbondy bbondy mentioned this issue Oct 13, 2016
Open
This was referenced Oct 14, 2016
Closed
Closed
Closed
Closed
This was referenced Oct 16, 2016
Closed
Closed
Closed
Closed
bbondy added a commit to brave-experiments/ad-block that referenced this issue Oct 25, 2016
@bbondy
Ignore ping requests for now
afc4d2c 
Fix brave/browser-laptop#4633
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
feature/adblock QA/checked-macOS QA/checked-Win32
Projects
None yet
Milestone
0.12.5dev
Development

No branches or pull requests
3 participants
@bbondy @alexwykoff @luixxiul