Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Creating bookmarks and bookmark folders breaks the UI #4778

Closed
bbondy opened this issue Oct 14, 2016 · 1 comment
Closed

Creating bookmarks and bookmark folders breaks the UI #4778

bbondy opened this issue Oct 14, 2016 · 1 comment
Labels
QA/checked-macOS QA/checked-Win32 QA/checked-Win64 regression
Milestone
0.12.5dev

Comments

@bbondy
Copy link
Member

bbondy commented Oct 14, 2016

Did you search for similar issues before submitting this one?
yes

Describe the issue you encountered:
Right clicking on your bookmarks toolbar and adding a bookmark breaks the UI.
Sometimes you need to add a couple of items before it happens.
Drag and drop and tab loading doesn't work after you reproduce.

Expected behavior:
App should behave normally after adding a bookmark

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS
  • Brave Version:
    0.12.5-RC1
  • Steps to reproduce:
    1. I have my data imported from chrome, not sure if it matters
    2. Right click on the bookmarks toolbar and add a bookmark
    3. Enter a title and a URL
    4. Hit save
@bbondy bbondy added this to the 0.12.5dev milestone Oct 14, 2016
@bbondy
Copy link
Member Author

bbondy commented Oct 14, 2016

screenshot 2016-10-14 08 44 02

@bbondy bbondy mentioned this issue Oct 14, 2016
Closed
@bbondy bbondy closed this as completed in b90f90c Oct 15, 2016
bbondy added a commit that referenced this issue Oct 15, 2016
@bbondy
Fix non optimized tail recursive call stack overflow
5bf1ec0 
brave/immutable-js-patch@84e400e

Fix #4778

Corruption was only happening in packaged builds because the code isn't being tail recursive optimized and so the callstack would get huge and corrupted

Auditors: @bsclifton
bbondy added a commit that referenced this issue Oct 15, 2016
@bbondy
Fix non optimized tail recursive call stack overflow
2c3c891 
brave/immutable-js-patch@84e400e

Fix #4778

Corruption was only happening in packaged builds because the code isn't being tail recursive optimized and so the callstack would get huge and corrupted

Auditors: @bsclifton
This was referenced Oct 16, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Oct 18, 2016
Closed
102 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
QA/checked-macOS QA/checked-Win32 QA/checked-Win64 regression
Projects
None yet
Milestone
0.12.5dev
Development

No branches or pull requests
4 participants
@bbondy @alexwykoff @luixxiul @srirambv