Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

l10n of ledger advanced settings modal window #4786

Closed
luixxiul opened this issue Oct 14, 2016 · 6 comments · Fixed by #5705
Closed

l10n of ledger advanced settings modal window #4786

luixxiul opened this issue Oct 14, 2016 · 6 comments · Fixed by #5705
Assignees
Milestone

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: buttons on ledger advanced settings modal window are broken.

clipboard01

Expected behavior: Buttons should not word-wrap.

@luixxiul luixxiul added design A design change, especially one which needs input from the design team. l10n feature/rewards labels Oct 14, 2016
@luixxiul luixxiul added this to the 0.12.5dev milestone Oct 14, 2016
@bbondy
Copy link
Member

bbondy commented Oct 15, 2016

cc @jkup pls handle for 0.12.6

@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.5dev Oct 15, 2016
@mrose17 mrose17 modified the milestones: 0.12.7dev, 0.12.6dev Oct 17, 2016
@brave-office brave-office modified the milestones: 1.0.0, 0.12.7dev Oct 18, 2016
@jkup
Copy link
Contributor

jkup commented Oct 20, 2016

Sorry I didn't see this one until just now! I'll have it in tomorrow.

@bbondy
Copy link
Member

bbondy commented Oct 22, 2016

@jkup ping

@bbondy bbondy modified the milestones: 0.12.7dev, 1.0.0 Oct 22, 2016
@mrose17 mrose17 modified the milestones: 0.12.8dev, 0.12.7dev, 1.1.0 Oct 22, 2016
@luixxiul luixxiul modified the milestones: 0.12.11, 1.1.0 Nov 17, 2016
@luixxiul
Copy link
Contributor Author

luixxiul commented Nov 19, 2016

On Backup your wallet window you get this:

clipboard01

The commit 3bb9b15 of #5705 fixes it too into this:

screenshot 2016-11-20 1 52 29

@luixxiul
Copy link
Contributor Author

Test plan:

Modified 75a754a to update with the latest status:

  1. Open about:preferences#payments
  2. Make sure the font size of the two buttons "Add funds" and "Advanced Settings..." is equal
  3. Click "Advanced Settings..."
  4. Make sure each button is not wrapped

And 23207ed

  1. Click the bookmark button on the URL bar
  2. Make sure height of "Remove" and "Done" buttons is equal
  3. Make sure "Remove" button is longer than "Done" button
  4. Make sure color of "Remove" label is no longer white on hover
  5. Make sure width of the row of the buttons is equal to the other rows
  6. Open about:bookmarks and edit a bookmark
  7. Make sure height and width of "Remove" and "Done" are equal
  8. Open about:preferences#payments, click Advanced Settings and Backup your wallet
  9. Make sure keys and buttons are aligned
  10. Make sure font-size of the labels "Copy" is 14px

@luixxiul
Copy link
Contributor Author

Follow-up of this: 5th commit of #6047

screenshot 2016-12-15 3 32 43

The buttons are no longer aligned at the center.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants