Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

l10n of ledger advanced settings modal window #5718

Closed
wants to merge 1 commit into from

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Nov 17, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4786

Auditors @luixxiul @bsclifton

Test Plan:

  1. Change language to Japanese
  2. Go to Preferences > Payments
  3. Click on Advanced Settings (gray button at the top right)
  4. Make sure buttons are not broken like in this screenshot

broken

@jkup jkup added design A design change, especially one which needs input from the design team. QA/test-plan-specified labels Nov 17, 2016
@jkup jkup added this to the 0.12.11 milestone Nov 17, 2016
@luixxiul
Copy link
Contributor

Let's consider other languages than Japanese too.

@srirambv
Copy link
Collaborator

#5771 the text is fine but the buttons are too big and the done button is slipping below the recovery wallet button

@luixxiul
Copy link
Contributor

@srirambv it should be fixed once #5705 is merged

@jkup
Copy link
Contributor Author

jkup commented Nov 21, 2016

Where are we at on this ticket? @luixxiul I saw you had a few related CSS commits go through. Should I close this PR for now?

@luixxiul
Copy link
Contributor

@jkup yeah I think so. thanks in advance.

@jkup jkup closed this Nov 22, 2016
@bsclifton bsclifton deleted the advanced-settings-buttons branch November 22, 2016 06:34
@luixxiul luixxiul removed this from the 0.13.0 milestone Dec 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. QA/no-qa-needed QA/test-plan-specified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants