Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Setting Brave as default from the startup check on win7 doesn't work #4937

Closed
bbondy opened this issue Oct 19, 2016 · 0 comments · Fixed by brave/muon#75
Closed

Setting Brave as default from the startup check on win7 doesn't work #4937

bbondy opened this issue Oct 19, 2016 · 0 comments · Fixed by brave/muon#75
Assignees
@darkdh
Labels
OS/Windows QA/checked-Win64
Milestone
0.12.6dev

Comments

@bbondy
Copy link
Member

bbondy commented Oct 19, 2016

If you select Brave as the default browser on startup in Win7, then subsequent restarts will think it is the default browser. But typing into the Start | Run dialog https://www.brave.com leads to it using your previous default.

Please also make sure we're compatible with the registry keys that we setup from the installer here
res/braveDefaults.nsi

These keys were set so that control panel will recognize us as the default browser.

By the way the default browser handling changes in win8 and above as well.
@bbondy bbondy added this to the 0.12.6dev milestone Oct 19, 2016
darkdh added a commit to brave/muon that referenced this issue Oct 19, 2016
@darkdh
Add reading/writing UrlAssociations for default protocol get/set
7ab8325 
fix brave/browser-laptop#4937

Auditors: @bridiver, @bbondy
@darkdh darkdh mentioned this issue Oct 19, 2016
Merged
This was referenced Oct 20, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
OS/Windows QA/checked-Win64
Projects
None yet
Milestone
0.12.6dev
Development

Successfully merging a pull request may close this issue.

Add reading/writing UrlAssociations for default protocol get/set brave/muon
4 participants
@bbondy @Sh1d0w @darkdh @srirambv