Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Retry the URL" on cloned error tab is retried on the original tab #4984

Closed
luixxiul opened this issue Oct 20, 2016 · 2 comments · Fixed by #5015
Closed

"Retry the URL" on cloned error tab is retried on the original tab #4984

luixxiul opened this issue Oct 20, 2016 · 2 comments · Fixed by #5015
Assignees
@darkdh
Labels
QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.7dev

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: "Retry the URL" on cloned error tab is retried on the original tab.

retry

Expected behavior: It should retry on the cloned tab

  • Platform (Win7, 8, 10? macOS? Linux distro?): OS X
  • Brave Version: master branch
  • Steps to reproduce:
    1. Load a URL which results in connection timed out error
    2. Clone the tab
    3. Retry the URL
  • Any related issues: Allow about pages to reload and clone #4881
@luixxiul
Copy link
Contributor Author

cc: @darkdh

@bsclifton
Copy link
Member

bsclifton commented Oct 20, 2016 •
edited
Loading

Somewhat similar to behavior mentioned in this complaint (opening Brave while not having internet connection; lots of the pages throw an error. hit retry):
#4946

@darkdh darkdh self-assigned this Oct 20, 2016
@darkdh darkdh added this to the 0.12.7dev milestone Oct 20, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 20, 2016
@darkdh
Update frameKey in aboutDetails when clone about pages
57f1f91 
fix brave#4984

Auditors: @bsclifton

Test Plan:
1. generate error page (ex. connection lost)
2. clone the error tab
3. retry on the cloned tab of step2
4. reload should happen on the cloned tab
@darkdh darkdh mentioned this issue Oct 20, 2016
Merged
4 tasks
This was referenced Oct 26, 2016
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Oct 26, 2016
Closed
This was referenced Oct 27, 2016
Closed
Closed
Closed
Closed
This was referenced Oct 28, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.7dev
Development

Successfully merging a pull request may close this issue.

Update frameKey in aboutDetails when clone about pages darkdh/browser-laptop
5 participants
@alexwykoff @luixxiul @bsclifton @darkdh @srirambv