Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

error page infinite loop #5177

Closed
darkdh opened this issue Oct 27, 2016 · 2 comments · Fixed by #5178
Closed

error page infinite loop #5177

darkdh opened this issue Oct 27, 2016 · 2 comments · Fixed by #5178
Assignees
@darkdh
Labels
QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.7dev

Comments

@darkdh
Copy link
Member

darkdh commented Oct 27, 2016

Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
reload error page of DNS error will cause infinite reloading
Expected behavior:
the error page won't reload infinitely

  • Platform (Win7, 8, 10? macOS? Linux distro?): all
  • Brave Version: 0.12.6
  • Steps to reproduce:
    1. Type brave.123 in navigation bar
    2. After error page is presented, click refresh button next to navigation bar
    3. Press alt + cmd + i and you can see infinite reloading
  • Any related issues: Allow about pages to reload and clone #4881
@darkdh darkdh added this to the 0.12.7dev milestone Oct 27, 2016
@darkdh darkdh self-assigned this Oct 27, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 27, 2016
@darkdh
Handle reload by setUrl in window store
e25fc58 
fix brave#5177

Auditors: @bbondy

Test Plan:
1. Type brave.123 in navigation bar
2. After DNS error page is presented, click refresh button next to navigation bar
3. The error page refresh normally

1. Type brave.123 in navigation bar
2. After DNS error page is presented, click "Retry the URL" in error page
3. The error page refresh normally

1. Navigate to https://expired.badssl.com/
2. After cert error page is presented, click refresh button next to navigation bar
3. The error page refresh normally

1. Navigate to https://expired.badssl.com/
2. After cert error page is presented, click "Retry the URL" in error page
3. The error page refresh normally

1. Make network unavailable
2. Type anything in navigation bar
3. After connection error page is presented, click refresh button next to navigation bar
4. The error page refresh normally

1. Make network unavailable
2. Type anything in navigation bar
3. After connection error page is presented, click "Retry the URL" in error page
4. The error page refresh normally

1. Make network unavailable
2. Type anything in navigation bar
3. After connection error page is presented, make network available
4. Click refresh button next to navigation bar
5. The original page should load

1. Make network unavailable
2. Type anything in navigation bar
3. After connection error page is presented, make network available
4. Click "Retry the URL" in error page
5. The original page should load
@darkdh darkdh mentioned this issue Oct 27, 2016
Merged
4 tasks
@bsclifton
Copy link
Member

I wonder if this was causing #4502? In that issue, folks are reporting seeing an error page and it's flickering (possibly redrawing really quickly?)

@bsclifton bsclifton mentioned this issue Oct 27, 2016
Closed
This was referenced Oct 27, 2016
Closed
Closed
Closed
Closed
@darkdh
Copy link
Member Author

darkdh commented Oct 27, 2016

I think this is introduced in 0.12.6

This was referenced Oct 28, 2016
Closed
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Dec 9, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.7dev
Development

Successfully merging a pull request may close this issue.

Handle reload by setUrl in window store darkdh/browser-laptop
5 participants
@alexwykoff @luixxiul @bsclifton @darkdh @srirambv