Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Regression : about:bookmarks : context menu for bookmark should provide edit option regardless of whether or not it was selected first #5202

Closed
alexwykoff opened this issue Oct 27, 2016 · 0 comments · Fixed by #5206
Closed

Regression : about:bookmarks : context menu for bookmark should provide edit option regardless of whether or not it was selected first #5202

alexwykoff opened this issue Oct 27, 2016 · 0 comments · Fixed by #5206
Assignees
@bsclifton
Labels
QA/checked-macOS QA/checked-Win64 regression
Milestone
0.12.7dev

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When right-clicking on a bookmark in about:bookmarks, I expected an edit bookmark option. There was none.

Expected behavior:
Regardless of whether or not you select the bookmark first, you should have the option to edit it via the context menu.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X
  • Brave Version:
    0.12.7 RC1
  • Steps to reproduce:
    1. Go to about:bookmarks
    2. Right-click on a bookmark
    3. Look for an edit option
  • Screenshot if needed:
  • Any related issues:
@alexwykoff alexwykoff added this to the 0.12.7dev milestone Oct 27, 2016
@bsclifton bsclifton self-assigned this Oct 27, 2016
@bsclifton bsclifton mentioned this issue Oct 27, 2016
Merged
4 tasks
bbondy pushed a commit that referenced this issue Oct 28, 2016
@bsclifton @bbondy
Context menu now works on sortableTable with no selection
9c79085 
Also fixes: focus for new folder / edit folder / new bookmark now set properly

Fixes #5202

Auditors: @darkdh
This was referenced Oct 28, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
QA/checked-macOS QA/checked-Win64 regression
Projects
None yet
Milestone
0.12.7dev
Development

Successfully merging a pull request may close this issue.

Context menu now works on sortableTable with no selection
3 participants
@alexwykoff @bsclifton @srirambv