Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Browser is blurry if DPI is greater than 100% #5926

Closed
srirambv opened this issue Nov 30, 2016 · 8 comments · Fixed by brave/muon#124
Closed

Browser is blurry if DPI is greater than 100% #5926

srirambv opened this issue Nov 30, 2016 · 8 comments · Fixed by brave/muon#124

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 30, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Browser looks like its set at 200% magnification

Expected behavior:
Should respect the system magnification settings

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    0.13.0 Preview 2

  • Steps to reproduce:

    1. Right click desktop > Display settings
    2. Pick a DPI higher than 100% (ex: 150%) and close window
    3. Logout or restart and then log back in again
    4. Launch Brave (Chromium 54 build) and notice the problem
  • Screenshot if needed:
    image

  • Any related issues:

@bradleyrichter
Copy link
Contributor

@bsclifton Can you reproduce and check if a flag changed?

@bsclifton
Copy link
Member

bsclifton commented Dec 7, 2016

Reproduced; looks great at 100% but then gets blurry at 125%. I made sure to log out and log back in after upping my DPI to 125% too.

Here's a screenshot that (hopefully) shows how blurred things get (be sure to click to see image at it's full size):
screen shot 2016-12-07 at 11 05 50 am

@bsclifton bsclifton changed the title Browser looks like its set at 200% magnification by default Browser is blurry if DPI is greater than 100% Dec 7, 2016
@bsclifton
Copy link
Member

I tried the command-line options shown as a work-around here without luck (and many variations of it):
https://bugs.chromium.org/p/chromium/issues/detail?id=395425

app/index.js

app.commandLine.appendSwitch('enable-use-zoom-for-dsf', 'false')
app.commandLine.appendSwitch('high-dpi-support', 'true')
app.commandLine.appendSwitch('force-device-scale-factor', 'true')

@darkdh darkdh assigned darkdh and unassigned bsclifton Dec 16, 2016
@darkdh
Copy link
Member

darkdh commented Dec 17, 2016

window.devicePixelRatio isn't correct on my VM. In 53, it is 2 but 1 in 54.

@luixxiul
Copy link
Contributor

Test plan:

Right click desktop > Display settings
Pick a DPI higher than 100% (ex: 150%) and close window
Logout or restart and then log back in again
Launch Brave

@bsclifton
Copy link
Member

Added release-notes/exclude; this was introduced with 0.13.0

@srirambv
Copy link
Collaborator Author

Except Bookmark modal(#6777) and autofill modal the rest looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants