-
Notifications
You must be signed in to change notification settings - Fork 975
Window border not always shown on all sides (when using high DPI) #6698
Comments
Able to repro and it may be related to #6462 Here's what my best guess is (which may be wrong, but hear me out). Frameless windows should NOT have any non-client area... but for some (in Muon) reason they do. When an approach is taken to disregard non-client area, we saw with #4216 that at 200% DPI, the top right / top left borders become rounded. When the DPI is NOT 100% (or another round number, like 200%), you have an odd number of pixels. What I believe is happening is that the width/height of the window... when calculated... is not adding up to the actual width/height of the Window I have a pretty good idea of where to look. Stay tuned... |
This is a fairly complex problem and will take some time to solve. Although high DPI Windows users may have some ugliness, Brave is still very usable; I don't believe this should be a blocker for 0.13.0. I'm going to move this to 0.13.1 😄 |
My findings so far
I ran a quick demo with logging and observed that:
When I’m inside the layout object, I can output the size of the view itself (I believe this is the webcontents) and the parent (the “host”). These sizes are: |
Some data I collected when reproducing
If you manually work out the conversion to 125%, it would be 1011.25 x 747.5. It seems that any non-integer value is rounding up for the size of the HWND? In this situation:
|
This one is solvable, but low priority
I'm going to push it back; please feel free to re-assign milestone if you disagree |
Closing as |
Did you search for similar issues before submitting this one?
yes
Describe the issue you encountered:
Window border not shown on all sides
Expected behavior:
Should show the blue window border on all sides when browser is in focus
Platform (Win7, 8, 10? macOS? Linux distro?):
Windows 10 x64
Brave Version (revision SHA):
Brave 0.13.0
rev 105a1a7
Same on preview 8 as well
Steps to reproduce:
QA Steps
Screenshot if needed:
Preview 8
Preview 9
cc: @bsclifton
The text was updated successfully, but these errors were encountered: