Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed window border on Windows: focused blue / unfocused gray (broke ~0.15.0) #8778

Closed
bsclifton opened this issue May 9, 2017 · 2 comments

Comments

@bsclifton
Copy link
Member

bsclifton commented May 9, 2017

Test plan

  1. Launch Brave on Windows and ensure the window has a blue-ish border
  2. Make the window small enough that you focus on another item (like empty doc in notepad) and still see Brave
  3. When Brave loses focus, it should get a gray border
  4. When Brave gets focus again, it should get back the blue-ish border

Original issue description

Windows will usually have the blue border when a window is focused which turns into a gray border when the window loses focus. This functionality was broken with 901d5db and was never restored. The single window action onFocusChanged was split out into onFocus and onBlur, but nothing calls them

@bsclifton bsclifton self-assigned this May 9, 2017
@bsclifton bsclifton added this to the 0.15.300 milestone May 9, 2017
bsclifton added a commit that referenced this issue May 9, 2017
@bsclifton bsclifton changed the title Windows no longer have proper border when focused/unfocused Fixed window border on Windows: focused blue / unfocused gray (broke ~0.15.0) May 9, 2017
bsclifton added a commit that referenced this issue May 10, 2017
kspearrin pushed a commit to kspearrin/browser-laptop that referenced this issue May 11, 2017
@srirambv
Copy link
Collaborator

Still right bluish border is missing on 0.15.301. @bsclifton is this still expected behavior on Windows?

@bsclifton
Copy link
Member Author

@srirambv yes- this is captured with #6698

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.