Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refinements to Add Funds URL Include Button #6754

Closed
3 tasks done
bradleyrichter opened this issue Jan 20, 2017 · 9 comments
Closed
3 tasks done

Refinements to Add Funds URL Include Button #6754

bradleyrichter opened this issue Jan 20, 2017 · 9 comments

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jan 20, 2017

image

image

@luixxiul
Copy link
Contributor

fix render gap to match left-side bookmark button

border-radius: @borderRadiusURL;
border-top-left-radius: 0;
border-bottom-left-radius: 0;

Change

border-radius: @borderRadiusURL;
border-top-left-radius: 0;
border-bottom-left-radius: 0;

Into

border-radius: 0;

Done! ;-)

@luixxiul
Copy link
Contributor

luixxiul commented Feb 1, 2017

the milestone was reset to 0.13.3

@bsclifton
Copy link
Member

I believe this issue is still open and needs a resolution. The latest solution can be found at #6862 (comment)

But it's not implemented yet

@bsclifton bsclifton reopened this Feb 4, 2017
@luixxiul luixxiul modified the milestones: 0.13.3, 0.13.2 Feb 4, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Feb 4, 2017

the milestone was modified

@luixxiul
Copy link
Contributor

luixxiul commented Feb 4, 2017

Note: when you close the issue please do not forget to include #6592 too.

@bsclifton
Copy link
Member

@luixxiul is auto-include sites is available in 0.13.2? if so, the icon used is a deal-breaker (per the notes linked to). It should be excluded from the RC

@luixxiul
Copy link
Contributor

luixxiul commented Feb 5, 2017

is auto-include sites is available in 0.13.2?

I see the option on about:preferences#payments but not sure if it works as it should and how to know it.

I don't see any icon next to the URL bar.

@bsclifton
Copy link
Member

Moving milestone back to 0.13.2 and marking this as a blocker. We can't ship auto-include sites with the original bitcoin icon (shown above) per request by @BrendanEich. The icon which was included with #6862 (comment) has open (unaddressed) security concerns

We can either:

  • Back the auto-include sites commits out from 0.13.2
  • Fix the icon
  • Ship with a not ideal icon

cc: @bradleyrichter @bbondy

@bsclifton bsclifton modified the milestones: 0.13.2, 0.13.3 Feb 5, 2017
@bbondy
Copy link
Member

bbondy commented Feb 5, 2017

Is this really a blocker? I don't see the linked to UI in the URL bar whether the option is on or off. I think people will just not know what it is for and so we can just move it to the next milestone. At this point everything else is taken care of so I don't want to respin an RC6 for only this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.