Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Fixed the regression of unclickable buttons under #navigator
Browse files Browse the repository at this point in the history
This fixes the regression I unintentionally introduced with 19360c1#diff-02c4b23ad267fe636760179e32fa29ceR842 for #6035

Fixes #6680
Closes #6253

Auditors: @bsclifton

Test Plan:
1. Make sure every button on the navigation bar is clickable
2. Open https://jsfiddle.net/
3. Block scripts from the top right lion icon
4. Make sure the noScript button on the navigation bar is clickable
  • Loading branch information
Suguru Hirahara committed Jan 16, 2017
1 parent 9a98903 commit 2a78248
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions less/navigationBar.less
Original file line number Diff line number Diff line change
Expand Up @@ -574,8 +574,6 @@
background: white;
box-shadow: 0px 1px 5px 0px rgba(0, 0, 0, 0.15);
}

-webkit-app-region: no-drag;
}

.noScriptButtonContainer {
Expand Down Expand Up @@ -705,6 +703,11 @@
-webkit-user-select: none;
z-index: @zindexNavigationBar;

// #6253 #6680
> * {
-webkit-app-region: no-drag;
}

form {
-webkit-app-region: drag;
// Disable window dragging so that selecting text and dragging the favicon is possible.
Expand Down Expand Up @@ -828,7 +831,6 @@
> * {
position: relative;
top: 1px;
-webkit-app-region: no-drag;
}

.inputbar-wrapper {
Expand Down

0 comments on commit 2a78248

Please sign in to comment.