Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab size change should have transition animation #7001

Closed
luixxiul opened this issue Feb 2, 2017 · 5 comments · Fixed by #11438
Closed

Tab size change should have transition animation #7001

luixxiul opened this issue Feb 2, 2017 · 5 comments · Fixed by #11438

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Feb 2, 2017

Test plan

#11438 (comment)


Describe the issue you encountered: Tab size change after closing tabs should have animation.

  • Brave Version (revision SHA): master branch

  • Steps to reproduce:

    1. open 7-8 tabs (doesn't matter what the content is; can be empty)
    2. move your cursor to the close button of the second tab from left
    3. Now as you keep clicking it will maintain the size of the tabs
    4. The size will reset as soon as you move your cursor outside the tab area.
  • Actual result: the size is reset without animation

  • Expected result: the size should be reset with transition animation

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues: Keep tabs same size when closing #6088

@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 2, 2017

CC @bradleyrichter for a comment

@petemill petemill self-assigned this Oct 11, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Oct 11, 2017
…a mouseover tab close button followed by a mouseout

Fix brave#7001
petemill added a commit to petemill/browser-laptop that referenced this issue Oct 13, 2017
…a mouseover tab close button followed by a mouseout

Fix brave#7001
@cezaraugusto cezaraugusto added this to the 0.22.x (Nightly Channel) milestone Oct 14, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
…a mouseover tab close button followed by a mouseout

Fix brave#7001
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@srirambv
Copy link
Collaborator

srirambv commented Jun 14, 2018

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified with macOS 10.12.6 using

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

@kjozwiak
Copy link
Member

Once you've closed a tab and move the mouse away from the tabs toolbar, the animation doesn't trigger unless you hover over a tab that has already been created. The animation should be triggering whenever a user closes a tab and moves the cursor away from the tabs toolbar.

STR:

  • open about ~15 new tabs using 0.23.11 6565c06
  • close the tab that's all the way at the end of the tab toolbar and drag the mouse onto the page
  • notice that the animation isn't triggered
  • move the mouse over one of the already created tabs and you'll notice the animation triggering.

Example of issue:

animationexample

Platforms:

  • macOS 10.13.4 x64 - Reproduced using 0.23.11` 6565c06
  • Win 10 x64 - Reproduced using 0.23.11` 6565c06
  • Ubuntu 18.04 x64 - Reproduced using 0.23.11` 6565c06

@kjozwiak kjozwiak reopened this Jun 20, 2018
@petemill
Copy link
Member

@kjozwiak I discovered the issue you found is a regression due to some other changes, and would have happened without the animation this issue calls for, so created a new issue and will close this re-open in favor of #14477

@srirambv
Copy link
Collaborator

srirambv commented Jun 25, 2018

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.16 2042c45
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.17 - bc754eb
  • Muon - 7.1.2
  • libchromiumcontent - 67.0.3396.87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.