Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clicking on disabled Ad/Tracker count enables the <li> element under braveryPanelBody #7026

Closed
srirambv opened this issue Feb 3, 2017 · 0 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 3, 2017

Test plan

#8958 (comment)


  • Did you search for similar issues before submitting this one? Yes

  • Describe the issue you encountered: Clicking on Ad/Tracker even when disabled enables the <li> items under braveryPanelBody

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 x64

  • Brave Version (revision SHA): Brave 0.13.2 rev 8cdf402

  • Steps to reproduce:

    1. Open any site
    2. Click on Shields menu and disable shields so that all entries are 0
    3. Click on Ad/Tracker count, you can see the
    4. element enabled
    5. Click on other entries, nothing happens
  • Actual result: Clicking on disabled Ad/Tracker count enables the <li> element

  • Expected result: <li> element should only be enabled when Ad/Tracker is enabled and has count

  • Will the steps above reproduce in a fresh profile? If not what other info can be added? Yes

  • Is this an issue in the currently released version? Yes existing behavior

  • Can this issue be consistently reproduced? Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    shieldsmenu

  • Any related issues:

@srirambv srirambv added this to the 1.0.0 milestone Feb 3, 2017
@luixxiul luixxiul removed this from the 1.0.0 milestone Feb 3, 2017
@luixxiul luixxiul added polish Nice to have — usually related to front-end/visual tasks. priority/low and removed feature/shields labels Feb 3, 2017
@luixxiul luixxiul added this to the contributor backlog milestone Feb 3, 2017
@luixxiul luixxiul removed this from the contributor backlog milestone May 1, 2017
kumarrishav added a commit to kumarrishav/browser-laptop that referenced this issue May 19, 2017
@luixxiul luixxiul added this to the 0.15.400 milestone May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants