Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

page shortcuts should work outside of webview #740

Closed
diracdeltas opened this issue Feb 11, 2016 · 2 comments
Closed

page shortcuts should work outside of webview #740

diracdeltas opened this issue Feb 11, 2016 · 2 comments
Labels
needs-info Another team member needs information from the PR/issue opener.

Comments

@diracdeltas
Copy link
Member

probably need to be js keydown handlers in browser index.html, cf 83f116b
diracdeltas referenced this issue Feb 11, 2016
@diracdeltas
Don't use cmd+<arrow> as a local shortcut
83f116b 
It needs to know whether the element in focus is editable so it doesn't override
going to the beginning/end of the line.

Fix #723

Auditors: @bbondy
@cezaraugusto
Copy link
Contributor

@diracdeltas was it fixed?

@cezaraugusto cezaraugusto added the needs-info Another team member needs information from the PR/issue opener. label Jun 15, 2016
@diracdeltas
Copy link
Member Author

I don't think so but I'm not sure which page shortcuts I was referring to here. I think they can be added on a case-by-case basis when needed, so I'll close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs-info Another team member needs information from the PR/issue opener.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diracdeltas @cezaraugusto