Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Don't use cmd+<arrow> as a local shortcut
Browse files Browse the repository at this point in the history 
It needs to know whether the element in focus is editable so it doesn't override
going to the beginning/end of the line.

Fix #723

Auditors: @bbondy
  • Loading branch information
@diracdeltas
diracdeltas committed Feb 11, 2016
1 parent c320a2b commit 83f116b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions app/localShortcuts.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ module.exports.register = (win) => {
['CmdOrCtrl+Alt+Left', messages.SHORTCUT_PREV_TAB],
['CmdOrCtrl+Alt+Right', messages.SHORTCUT_NEXT_TAB],
['CmdOrCtrl+Alt+Left', messages.SHORTCUT_PREV_TAB],
['CmdOrCtrl+9', messages.SHORTCUT_SET_ACTIVE_FRAME_TO_LAST],
['CmdOrCtrl+Left', messages.SHORTCUT_ACTIVE_FRAME_BACK],
['CmdOrCtrl+Right', messages.SHORTCUT_ACTIVE_FRAME_FORWARD]
['CmdOrCtrl+9', messages.SHORTCUT_SET_ACTIVE_FRAME_TO_LAST]
]

if (process.platform === 'win32') {
Expand Down

2 comments on commit 83f116b

@bbondy
Copy link
Member

@bbondy bbondy commented on 83f116b Feb 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thanks for fixing my bustage but I think we also need to handle these shortcuts from within the window chrome too.

@diracdeltas
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened #740

Please sign in to comment.