Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Unhide bitwarden password manager #7921

Closed
bsclifton opened this issue Mar 27, 2017 · 22 comments · Fixed by #8829
Closed

Unhide bitwarden password manager #7921

bsclifton opened this issue Mar 27, 2017 · 22 comments · Fixed by #8829

Comments

@bsclifton
Copy link
Member

bsclifton commented Mar 27, 2017

Test plan

#8829 (comment)
#6918 (comment)


Once #7830 is supported, we can revert 0744193

#7919 #4776

@kspearrin
Copy link
Contributor

Can we unhide now that #7830 is closed?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label May 8, 2017
@bsclifton
Copy link
Member Author

@kspearrin absolutely- we'll need a new version of Muon. I'll set a milestone for the release after the current one. If you'd like, you could submit a revert of the above as a PR 😄

@bsclifton bsclifton added this to the 0.15.4 milestone May 9, 2017
@kspearrin
Copy link
Contributor

@bsclifton Done. #8776

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label May 11, 2017
@kspearrin
Copy link
Contributor

I somehow screwed up #8776 into a state that I didn't know how to recover from, so I started over with #8829. Sorry :-/

@kspearrin
Copy link
Contributor

@bsclifton Just trying to get an idea here. We'd like to prepare some announcement material to inform our users. What version of brave is slated to have bitwarden available in it?

@bsclifton
Copy link
Member Author

@kspearrin comment left here:
#6918 (comment)

Basically, it's in our 0.17.x releases. Here's a link to the latest, if you wanted to test it out 😄
https://github.com/brave/browser-laptop/releases/tag/v0.17.1dev

We should be able to ship within 1-2 weeks 😄

@kspearrin
Copy link
Contributor

@bsclifton How do extension updates work in brave? I'm testing with 0.17.1 and am getting a very outdated version of bitwarden (1.10.0) that is full of issues because it's using server APIs that are not backwards compat anymore.

@bsclifton
Copy link
Member Author

@kspearrin right now, it's a manual process we have to run (I'm looking at automating the update process). I should be able to safely bump bitwarden without an issue. Hang tight...

@kspearrin
Copy link
Contributor

@bsclifton Ok, no worries. We do have a somewhat critical update coming out today or tomorrow that I would like to ensure brave gets updated to before the release.

@kspearrin
Copy link
Contributor

@bsclifton Issue created #9479

@luixxiul
Copy link
Contributor

The bitwarden icon is not displayed on a web page, while it is on an about page such as about:preferences.

a

@jonathansampson
Copy link
Collaborator

@kspearrin I'm about to take a closer look at this issue. Aiming to resolve asap, and ship.

@kspearrin
Copy link
Contributor

@jonathansampson ok. Please let me know if/when there is a branch I can look at/test.

Also, we just pushed a new version, 1.14.2 , to the chrome store today. It would be nice if that update made it in as well since I know auto updates is a missing feature at the moment.

@bsclifton
Copy link
Member Author

@kspearrin good call- we do need to unhide it. This issue was closed prematurely when a different commit / issue was resolved. I'll re-open and unhide it shortly

@bsclifton bsclifton reopened this Jul 27, 2017
bsclifton added a commit that referenced this issue Jul 27, 2017
@bsclifton
Copy link
Member Author

Issue is now resolved after committing 2c2e19a 😄

cc: @kspearrin, @jonathansampson, @luixxiul

@bsclifton
Copy link
Member Author

@kspearrin you can try it out using the 0.18.x branch OR if you wait until we have a new build on the dev channel (if you have preview releases enabled- see advanced tab of preferences). We may have a new packaged build tonite or tomorrow

@kspearrin
Copy link
Contributor

@bsclifton I will wait for the new dev build.

@bsclifton
Copy link
Member Author

Tentatively moving to 0.19.x - we've got it disabled for now because of issues we ran into. We'll continue working away at those and plan to release with 0.19.x

@bsclifton
Copy link
Member Author

Let's track this with #4776 instead

@bsclifton bsclifton removed this from the 0.19.x (Beta Channel) milestone Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.