You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Describe the issue you encountered: Refactor loginRequired.js with Aphrodite, applying .commonForm (which shall be implemented with PR #7995) instead of .genericForm
Currently there are only three other instances where .genericForm is applied (autofillAddressPanel.js, autofillCreditCardPanel.js, and addEditBookmarkHanger.js), and in every case styles which genericForm defines are overwritten by what commonForm is going to do so (title color, padding inside the dialog, etc). Keeping both of them is a cause of style inconsistency.
Test plan
#8011 (comment)
Describe the issue you encountered: Refactor loginRequired.js with Aphrodite, applying
.commonForm
(which shall be implemented with PR #7995) instead of.genericForm
Currently there are only three other instances where
.genericForm
is applied (autofillAddressPanel.js, autofillCreditCardPanel.js, and addEditBookmarkHanger.js), and in every case styles which genericForm defines are overwritten by what commonForm is going to do so (title color, padding inside the dialog, etc). Keeping both of them is a cause of style inconsistency.The text was updated successfully, but these errors were encountered: