This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactor loginRequired.js with Aphrodite and commonForm #8011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From: To: |
This was referenced Apr 1, 2017
- textbox and textbox__outlineable were copied from textbox.js to commonStyles.js Since FormTextbox cannot be used for the input elements, I copied the styles applied for that element and applied to them. See: #7164 (comment) The labels and input forms were grouped and placed with display:flex and justify-content:space-between. Also the elements inside each wrapper were aligned equally to make the length of the input forms always equal (l10n friendly). Also colons in the label were removed to make the style consistent. Closes #8009 Addresses #8010 Auditors: Test Plan: 1. Visit http://browserspy.dk/password.php 2. Click "password-ok.php" link 3. Make sure you can log in successfully with the given credential 4. Change the lang setting on about:preferences 5. Try the same steps above and make sure the length of the input forms is equal
luixxiul
added
PR/needs-QA-attention ☕
and removed
PR/needs-rebase ۞
PR/work-in-progress ⚒
labels
Also: - Replaced aphrodite with aphrodite/no-important on textbox.js - Moved the styles from loginRequired.js to commonForm.js Auditors: Test Plan: n/a
4 tasks
4 tasks
|
@NejcZdovc would you mind reviewing the PR when you have some time? There are several PRs dependent on this one. As I will push the PR once again to the master once everything which should include |
|
@luixxiul sure, will review it in couple of hours |
NejcZdovc
approved these changes
Apr 7, 2017
| <Button l10nId='ok' className='primaryButton' onClick={this.onSave.bind(this)} /> | ||
| { | ||
| !this.isFolder | ||
| ? <div id='loginInput' className={css( |
There was a problem hiding this comment.
Not quite sure. We could remove them later if we would.
|
This looks great! Awesome job, @luixxiul! すごい!!! 😄 |
bsclifton
added
QA/test-plan-specified
release-notes/include
and removed
PR/needs-QA-attention ☕
labels
|
@bsclifton Arigato!! |
|
Note: this change is not yet available on master. I will push a PR to the master once every change which |
This was referenced Apr 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor loginRequired.js with Aphrodite and commonForm
Since FormTextbox cannot be used for the input elements (because the prop
ref={}cannot be got), I copied the styles applied for that element and applied to them. See: #7164 (comment)The labels and input forms were grouped and placed with display:flex and justify-content:space-between. Also the elements inside each wrapper were aligned equally to make the length of the input forms always equal (l10n friendly).
Also colons in the label were removed to make the style consistent.
Closes #8009
Addresses #8010
Auditors:
Test Plan:
git rebase -ito squash commits (if needed).