Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Test are failing on linux #8506

Closed
NejcZdovc opened this issue Apr 26, 2017 · 6 comments
Closed

Test are failing on linux #8506

NejcZdovc opened this issue Apr 26, 2017 · 6 comments

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 26, 2017

Test plan

  • run npm run watch-test
  • in new terminal npm run test

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Tests are not working on linux

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    linux, ubuntu 16.04 LTS
    pasted image at 2017_04_26 10_15 am

  • Brave Version (revision SHA):
    8da5411

  • Steps to reproduce:

    1. create a fresh linux VM
    2. install everything needed for running our development (check out versions in the print screen)
    3. run npm run watch-test and then in new terminal npm run test
  • Actual result:
    pasted image at 2017_04_26 10_48 am

  • Expected result:
    Test starts working

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    no

  • Can this issue be consistently reproduced?
    yes

Similar scenario
When you run TEST_DIR=about npm run testsuite you get failing tests which can be find in the first print screen.

@bbondy
Copy link
Member

bbondy commented Apr 26, 2017

@bsclifton this is because test/taxonomy/exclusionListTest.js uses levelup for taxonomy. What does this actually test? I don't see it using any module in particular except for levelup. Maybe we can create a different repo for this? I'll skip it for now and commit.

@bbondy
Copy link
Member

bbondy commented Apr 26, 2017

I think it should either test a module we have or we should just remove the file completely. If it's just testing leveldown then that should be in a leveldown repo.

bbondy added a commit that referenced this issue Apr 26, 2017
Related #8506

Auditors: @bsclifton

It causes problems with us using a different ABI than Node
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Apr 26, 2017

@bbondy I deleted the whole taxonomy folder and the error is gone, but test's are still failing. Note taxonomy folder is not used in travis. We are running testsuits on travis for a specific folder.

image

bbondy added a commit that referenced this issue Apr 26, 2017
Related #8506

Auditors: @bsclifton

It causes problems with us using a different ABI than Node
@bsclifton
Copy link
Member

Thanks for disabling! This is one just to perform quick sanity checks against what is returned when querying leveldb. We have made mistakes in the past with rules which caused some problems (which then required cleanup).

It would be much better if we had a way to test against the DB directly... but this test is interesting because it'll force the data to get pulled down and then run the test, same as running in-browser would

@bsclifton
Copy link
Member

More info can be found in 09690a8

@NejcZdovc
Copy link
Contributor Author

this was fixed so closing it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.