-
Notifications
You must be signed in to change notification settings - Fork 975
Test are failing on linux #8506
Comments
@bsclifton this is because test/taxonomy/exclusionListTest.js uses levelup for taxonomy. What does this actually test? I don't see it using any module in particular except for levelup. Maybe we can create a different repo for this? I'll skip it for now and commit. |
I think it should either test a module we have or we should just remove the file completely. If it's just testing leveldown then that should be in a leveldown repo. |
Related #8506 Auditors: @bsclifton It causes problems with us using a different ABI than Node
@bbondy I deleted the whole |
Related #8506 Auditors: @bsclifton It causes problems with us using a different ABI than Node
Thanks for disabling! This is one just to perform quick sanity checks against what is returned when querying leveldb. We have made mistakes in the past with rules which caused some problems (which then required cleanup). It would be much better if we had a way to test against the DB directly... but this test is interesting because it'll force the data to get pulled down and then run the test, same as running in-browser would |
More info can be found in 09690a8 |
this was fixed so closing it |
Test plan
run npm run watch-test
npm run test
Did you search for similar issues before submitting this one?
yes
Describe the issue you encountered:
Tests are not working on linux
Platform (Win7, 8, 10? macOS? Linux distro?):
linux, ubuntu 16.04 LTS
Brave Version (revision SHA):
8da5411
Steps to reproduce:
npm run watch-test
and then in new terminalnpm run test
Actual result:
Expected result:
Test starts working
Will the steps above reproduce in a fresh profile? If not what other info can be added?
yes
Is this an issue in the currently released version?
no
Can this issue be consistently reproduced?
yes
Similar scenario
When you run
TEST_DIR=about npm run testsuite
you get failing tests which can be find in the first print screen.The text was updated successfully, but these errors were encountered: