Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Video doesn't play when opened #8738

Closed
srirambv opened this issue May 6, 2017 · 3 comments
Closed

Video doesn't play when opened #8738

srirambv opened this issue May 6, 2017 · 3 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 6, 2017

Test plan

#8751 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Video doesn't play when opened

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.15.3
    rev 1c04c53

  • Steps to reproduce:

    1. Clean install 0.15.3 Preview 3
    2. Open a new tab and click on the YouTube tile
    3. Video buffers and after a min shows message If playback doesn't start, try restarting your device instead of playing the video immediately after loading the page
  • Actual result:
    Video doesn't autoplay

  • Expected result:
    Should play video when the link is opened

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    youtube

  • Any related issues:
    Block autoplay videos #2227 Add option to enable/disable HTML5 autoplay #4045 All video in Brave should default with autoplay=false, w/site level opt-in exceptions #7663
    cc: @jonathansampson @darkdh @bridiver

@srirambv srirambv added this to the 0.15.3 milestone May 6, 2017
@luixxiul
Copy link
Contributor

luixxiul commented May 6, 2017

It seems that it is because "allow autoplay media" is enabled by default.

Some kind of layer/popup/placeholder (with dark transparent background like modal dialog) definitely should be there in terms of UX. otherwise people would complain, "why did you guys stop autoplaying youtube video?"

@luixxiul
Copy link
Contributor

luixxiul commented May 6, 2017

I added my own first impression with a couple of suggestions: #8739

@darkdh darkdh self-assigned this May 6, 2017
@darkdh
Copy link
Member

darkdh commented May 6, 2017

I will apply 1. and 3. suggestions from #8739

darkdh added a commit that referenced this issue May 8, 2017
…low it

Display "Block autoplay" in bravey shield

Fix #8738
Fix #8739

Auditors: @bbondy, @bsclifton, @jonathansampson

Test Plan:
Covered by automatic test
darkdh added a commit that referenced this issue May 8, 2017
…ow it

Display "Block autoplay" in bravey shield

Fix #8738
Fix #8739

Auditors: @bbondy, @bsclifton, @jonathansampson

Test Plan:
Covered by automatic test
darkdh added a commit that referenced this issue May 9, 2017
…ow it

Display "Block autoplay" in bravey shield

Fix #8738

Auditors: @bbondy, @bsclifton, @jonathansampson

Test Plan:
Covered by automatic test
bsclifton pushed a commit that referenced this issue May 10, 2017
…ow it

Display "Block autoplay" in bravey shield

Fix #8738

Auditors: @bbondy, @bsclifton, @jonathansampson

Test Plan:
Covered by automatic test
bsclifton pushed a commit that referenced this issue May 10, 2017
…ow it

Display "Block autoplay" in bravey shield

Fix #8738

Auditors: @bbondy, @bsclifton, @jonathansampson

Test Plan:
Covered by automatic test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.