Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"open in new window" should cascade instead of layering at same x/y #8925

Closed
bradleyrichter opened this issue May 18, 2017 · 5 comments
Closed
Assignees
Labels
parity Features which should be supported in Brave since they're supported in other major browsers. polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include usability

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented May 18, 2017

Test plan

  1. Open Brave
  2. Use the menu and pick File > New Window
  3. A new window should appear and be offset (see example pics below). Offset should be ~20px

Original issue description

Cascade amount should be (x20px, y20px).

firefox example:

image

chrome example:
image

@bradleyrichter bradleyrichter added this to the 0.15.400 milestone May 18, 2017
@alexwykoff alexwykoff modified the milestones: 0.16.200, 0.16.100 May 23, 2017
@bsclifton bsclifton removed their assignment Jun 9, 2017
@bsclifton bsclifton added polish Nice to have — usually related to front-end/visual tasks. usability parity Features which should be supported in Brave since they're supported in other major browsers. and removed bug labels Jun 9, 2017
@alexwykoff alexwykoff modified the milestones: 0.19.x (Nightly Channel), 0.18.x (Developer Channel) Jun 13, 2017
@alexwykoff
Copy link
Contributor

similarly if you close and reopen brave, it would be wise to make sure we cascade.

@NejcZdovc NejcZdovc assigned bsclifton and unassigned NejcZdovc Jun 13, 2017
@NejcZdovc
Copy link
Contributor

Current findings:
We need to add some logic here https://github.com/brave/browser-laptop/blob/master/js/stores/appStore.js#L149

We need to check if user don't pass in any params about width/heigh we should cascade it.

Note that we also need to to change position when new position of cascaded is out of scope. We would like to do the same behavior as mac OS has. Move a finder window near to the window edge and create a new window. You will see that window is moved to another side where you have enough space. Same goes if you move it to the bottom it will be moved to the top if new window would be out site the scope.

@alexwykoff alexwykoff modified the milestones: 0.20.x (Developer Channel), 0.19.x (Beta Channel) Jul 18, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 16, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 17, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 18, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 25, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 25, 2017
@LaurenWags
Copy link
Member

@bradleyrichter @NejcZdovc using 0.20.7 when you open enough windows that you get to the bottom of your screen, Brave keeps opening windows offset to the right, but Chrome does something different, see gifs below. Do we want to offset in the same way Chrome does? cc @kjozwiak @srirambv @luixxiul

Brave:
brave-cascade

Chrome:
chrome-cascade

@bradleyrichter
Copy link
Contributor Author

I thought I was witness to seeing the correct behavior in @NejcZdovc code. So it must be a new bug.

@LaurenWags
Copy link
Member

Thanks @bradleyrichter - opened new issue for #8925 (comment) which is #12315

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
parity Features which should be supported in Brave since they're supported in other major browsers. polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include usability
Projects
None yet
Development

No branches or pull requests

7 participants