-
Notifications
You must be signed in to change notification settings - Fork 975
"open in new window" should cascade instead of layering at same x/y #8925
Comments
similarly if you close and reopen brave, it would be wise to make sure we cascade. |
Current findings: We need to check if user don't pass in any params about width/heigh we should cascade it. Note that we also need to to change position when new position of cascaded is out of scope. We would like to do the same behavior as mac OS has. Move a finder window near to the window edge and create a new window. You will see that window is moved to another side where you have enough space. Same goes if you move it to the bottom it will be moved to the top if new window would be out site the scope. |
Resolves brave#3754 Resolves brave#6602 Resolves brave#8600 Resolves brave#8925 Resolves brave#9709 Auditors: Test Plan:
Resolves brave#3754 Resolves brave#6602 Resolves brave#8600 Resolves brave#8925 Resolves brave#9709 Auditors: Test Plan:
Resolves brave#3754 Resolves brave#6602 Resolves brave#8600 Resolves brave#8925 Resolves brave#9709 Auditors: Test Plan:
Resolves brave#3754 Resolves brave#6602 Resolves brave#8600 Resolves brave#8925 Resolves brave#9709 Auditors: Test Plan:
Resolves brave#3754 Resolves brave#6602 Resolves brave#8600 Resolves brave#8925 Resolves brave#9709 Auditors: Test Plan:
@bradleyrichter @NejcZdovc using 0.20.7 when you open enough windows that you get to the bottom of your screen, Brave keeps opening windows offset to the right, but Chrome does something different, see gifs below. Do we want to offset in the same way Chrome does? cc @kjozwiak @srirambv @luixxiul |
I thought I was witness to seeing the correct behavior in @NejcZdovc code. So it must be a new bug. |
Thanks @bradleyrichter - opened new issue for #8925 (comment) which is #12315 |
Test plan
File
>New Window
Original issue description
Cascade amount should be (x20px, y20px).
firefox example:
chrome example:
The text was updated successfully, but these errors were encountered: