Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Improve tab tear-off sensitivity #9211

Closed
alexwykoff opened this issue Jun 2, 2017 · 25 comments
Closed

Improve tab tear-off sensitivity #9211

alexwykoff opened this issue Jun 2, 2017 · 25 comments
Assignees
Labels
bug feature/tabsbar feature/tear-off-tabs fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Jun 2, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Users in community are reporting that the vertical sensitivity is too tight which is causing accidental tear-offs when they aren't wanted.
    https://community.brave.com/t/oh-my-god-stop-with-the-tabs-to-new-windows/2473/22

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    0.15.314

  • Steps to reproduce:

    1. attempt to close or move tabs rapidly
  • Actual result:
    For some folks, a new window is created because of a small vertical movement

  • Expected result:
    The tab should either move or close as desired by the user.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Any related issues:
    Tear off tab - cursor is confusing while tearing off #8174
    Improve Drag and Drop for Tabs #6242

@alexwykoff alexwykoff added this to the 0.18.x milestone Jun 2, 2017
@alexwykoff alexwykoff modified the milestones: 0.19.x (Nightly Channel), 0.18.x (Developer Channel) Jun 23, 2017
@srirambv
Copy link
Collaborator

+1 from community #9211

@LaurenWags
Copy link
Member

@cndouglas
Copy link

+1 from #9992

@bsclifton
Copy link
Member

related: improve tab drag and drop: #6242

@cndouglas
Copy link

I think this should be reopened since it's a sub-task of #6242.

@luixxiul luixxiul reopened this Jul 19, 2017
@NejcZdovc NejcZdovc removed this from the 0.19.x (Beta Channel) milestone Jul 19, 2017
@eljuno
Copy link
Contributor

eljuno commented Jul 19, 2017

+1 from community

@bsclifton
Copy link
Member

+1 via #10007

Here's an animation showing the problem. The user is trying to drag a tab into a bookmark folder. It shouldn't be creating a new window
brave-drag-tab-to-folder-bug

@LaurenWags
Copy link
Member

@eljuno
Copy link
Contributor

eljuno commented Aug 26, 2017

+1 from community

@eljuno
Copy link
Contributor

eljuno commented Sep 14, 2017

@eljuno
Copy link
Contributor

eljuno commented Sep 20, 2017

@eljuno
Copy link
Contributor

eljuno commented Sep 24, 2017

+1 from community https://community.brave.com/t/tabs-getting-dragged-when-switching-tabs-with-mouse-clicks-also-alt-d-opens-up-the-menu-after-going-to-the-address-bar/8151?u=eljuno

when I am switching tabs with mouse clicks, it somehow undocks/drags itself out of the tabs area (try switching tabs with mouse clicks you might replicate the problem)

@spidawebs
Copy link

Is there any update on this? My tabs detach far too easily. They accidentally open in new windows about 10 times I day when I click on them and there is no way to attach them again to the original window. It's really annoying. I have to close the new window and open a new tab again in my original window.

@gnarlyman
Copy link

+1

@UppaJung
Copy link

Shocked this bug has been sitting unfixed for half a year. I also run into this constantly. Perhaps it's a pixel-based threshold and those not using 4k monitors don't feel the pain of this constantly?

@spidawebs
Copy link

Me too. I've had to stop using it and go back to Opera as it was driving me crazy.

@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.21.x (Beta Channel) Feb 14, 2018
@bsclifton bsclifton modified the milestones: 0.21.x (Beta Channel), 0.22.x (Developer Channel) Feb 15, 2018
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@TheMilesB
Copy link

This bug is really difficult from a user's productivity viewpoint.

Every time I try to click into a different open tab, it creates a new window... Then the new window jumps to the bottom right of my display, locating more than half the window out of the view of my monitor.

I really want to get behind Brave and share it with my audience, but this bug is just too frustrating, still.

@eljuno
Copy link
Contributor

eljuno commented Mar 27, 2018

+1 from community https://community.brave.com/t/too-sensitive-to-dragging-tabs/18647?u=eljuno

Every tab repeatedly gets detached into a new window when I try to click on it but unintentionally drag it because my hand wasn’t perfectly still.

@eljuno
Copy link
Contributor

eljuno commented Apr 4, 2018

@laradevitt
Copy link

I don't have particularly shaky hands or anything, but this happened to me three times in the last half hour. Not a deal breaker, but annoying sometimes.

@bsclifton bsclifton removed this from the 0.23.x (Developer Channel) milestone Jun 4, 2018
@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Jun 4, 2018
@bsclifton
Copy link
Member

Marking as wontfix since we'll get this for free with Brave Core

@bryanne99
Copy link

OMG - I tried Brave again a WHOLE year later!!! - just to see if the "tab tear-off issue has been fixed. Incredibly it hasn't. I will not waste my time trying to use itr again. I guess there's a reason why Chrome works - and that is because they just know how to make things work - as much as I would prefer NOT to use Google. This tabs issue is so incredibly frustrating that I just cannot use a browser that does that ...and no one seems to care???

@bsclifton
Copy link
Member

@bryanne99 we do care- enough that we're working on a replacement UI for what we have (based entirely on Chromium, versus what we have now which uses Muon, a fork of Electron). You can read more about it here:
https://brave.com/development-plans-for-upcoming-release/

Or you can check out / build the code yourself (we don't have any official releases yet):
https://github.com/brave/brave-browser

Besides having proper tear-off behavior, it has full extension support. If you're still willing to give us a shot, please check back in a few months

@sredenz
Copy link

sredenz commented Jul 22, 2018

I just signed up to GitHub to +1 for this request to change the sensitivity of undocking tabs (or give us an option to simply switch it off).

@jbcullis
Copy link

Yep, this one is pretty frustrating. I'm happy asides from this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug feature/tabsbar feature/tear-off-tabs fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.