Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Home button shouldn't respond to right click #9665

Closed
bsclifton opened this issue Jun 22, 2017 · 0 comments
Closed

Home button shouldn't respond to right click #9665

bsclifton opened this issue Jun 22, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
feature/navbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.17.13 (Release ...

Comments

@bsclifton
Copy link
Member

bsclifton commented Jun 22, 2017 •
edited by luixxiul
Loading

Test plan

#9672 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When the home button is shown, doing a right click on it will do the same action as a regular click.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS (but it happens on all)

  • Brave Version (revision SHA):
    HEAD on master

  • Steps to reproduce:

    1. Enable home button in preferences
    2. Right click home button

  • Actual result:
    Browser visits the home page

  • Expected result:
    Nothing should happen

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@bsclifton bsclifton added this to the 0.19.x (Nightly Channel) milestone Jun 22, 2017
@bsclifton bsclifton self-assigned this Jun 22, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.17.x (Beta Channel), 0.19.x (Nightly Channel) Jun 22, 2017
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned bsclifton Jun 22, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 22, 2017
@NejcZdovc
Fixes middle and right click for home button
4efc85b 
Resolves brave#9562
Resolves brave#9665

Auditors: @bsclifton

Test Plan:
- try to right click on the home button
- try middle clicking on the home button with title mode ON and OFF
@NejcZdovc NejcZdovc mentioned this issue Jun 22, 2017
Merged
8 tasks
This was referenced Jun 23, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/navbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

No branches or pull requests
5 participants
@alexwykoff @bsclifton @NejcZdovc @srirambv @LaurenWags