Delete history entry gets added back

[srirambv]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Delete history entry gets added back when sync is enabled

• Platform & Brave Version (revision SHA):
  0.17.9 (Pyramid 0) - Windows 10x64
  rev 2606974
  Muon 4.1.4

  0.17.6 (Pyramid 1) - Debian 8.0
  rev 30a3eee
  Muon 4.1.2

• Steps to reproduce:

  1. Enable Sync on Pyramid 0
  2. Sync pyramid 1 with pyramid using code words
  3. Enable browsing history on both pyramids
  4. Visit a site and ensure the history entry shows up on both devices
  5. Delete history entry on pyramid 0, adds an entry after the oldest history entry without date
  6. Delete history entry on pyramid 1, same as previous step

• Actual result:
  Delete history entry gets added back when sync is enabled

• Expected result:
  Should only delete and not add back

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  Not sure need to check on older builds

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  

• Any related issues:
  cc: @bsclifton please change milestone if required

[alexwykoff]

Since we're not blocking laptop on non-mobile blocking sync issues, let's punt this to 0.19.x and pull it up if fixed sooner.

[ayumi]

fwiw almost nobody syncs history because that's the default

[diracdeltas]

I see the same bug on a fresh profile without sync enabled. If you click 'delete history entry', the history entry just gets added back at the bottom of the list.

[bsclifton]

Similar behavior reported with #9736

[bsclifton]

@srirambv does this clear if you exit the browser? I believe the root cause is that history isn't cleared until you exit the browser (see #9736)

[cndouglas]

I think this is a duplicate of #8761.

[bsclifton]

@liunkae good find! Possibly also the same as #9736 and #9715

[srirambv]

@bsclifton quitting and restarting the browser doesn't clear the history unless clear history on exit is set

[diracdeltas]

closing as duplicate of #8761 since the behavior is the same with and without sync enabled