Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Only primitives in NavigationBar #9791

Closed
NejcZdovc opened this issue Jun 30, 2017 · 4 comments
Closed

Only primitives in NavigationBar #9791

NejcZdovc opened this issue Jun 30, 2017 · 4 comments
Assignees
@NejcZdovc
Labels
perf QA/no-qa-needed refactoring/redux-component release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

Describe the issue you encountered:
Remove sites from mergeProps. navbar will be removed in #9757
@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 30, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 30, 2017
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Jun 30, 2017 •
edited
Loading

@bsclifton @bridiver Any idea how to remove sites and activeFrame functions here.

First we need to get an active frame and his props window state. (https://github.com/brave/browser-laptop/blob/master/app/renderer/components/navigation/navigationBar.js#L61)

Second we need to get parentFolderId and customTitle for the current active frame app state

Third we need to call window action setBookmarkDetail, window state

@NejcZdovc
Copy link
Contributor Author

The only thing that I can remember and that would still somehow clean is create new window action, where we get app state directly and then we call setBookmarkDetail in this new action. wdyt?

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 30, 2017
@NejcZdovc
Removes non-primitive types from NavigationBar
d03851a 
Resolves brave#9791

Auditors: @bridiver @bsclifton

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jun 30, 2017
Closed
8 tasks
@NejcZdovc
Copy link
Contributor Author

PR created based on my last comment

@NejcZdovc
Copy link
Contributor Author

fixed with #9899

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
perf QA/no-qa-needed refactoring/redux-component release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
2 participants
@luixxiul @NejcZdovc