Fix isResourceEnabled jank using a cache

[diracdeltas]

fix #9987

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[bbondy]

I think instead of an app store listener on all events here we should handle the events that change site settings in a reducer and call into a cache module (braverySettingsCache) managed from the reducer and used in filtering.

[diracdeltas]

@bbondy i have updated the PR

[codecov-io]

Codecov Report

Merging #10289 into master will decrease coverage by 0.01%.
The diff coverage is 40.54%.

@@            Coverage Diff             @@
##           master   #10289      +/-   ##
==========================================
- Coverage   54.52%    54.5%   -0.02%     
==========================================
  Files         244      245       +1     
  Lines       21129    21157      +28     
  Branches     3262     3263       +1     
==========================================
+ Hits        11520    11532      +12     
- Misses       9609     9625      +16

Flag	Coverage Δ
#unittest	54.5% <40.54%> (-0.02%)	⬇️

Impacted Files	Coverage Δ
js/stores/appStore.js	12.3% <0%> (-0.16%)	⬇️
js/settings.js	98.46% <100%> (+1.53%)	⬆️
app/filtering.js	18.22% <11.76%> (+0.15%)	⬆️
app/common/cache/braverySettingsCache.js	60% <60%> (ø)

[diracdeltas]

@bbondy updated PR