Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

First quick check if lastEmittedState and appState are different #10498

Merged
merged 1 commit into from
Aug 15, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 15, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #10195

Auditors: @bridiver @bbondy

Test Plan:

  • open two windows
  • add bookmark in one
  • bookmark should appear in both bookmark toolbars

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#10195

Auditors: @bridiver @bbondy

Test Plan:
- open two windows
- add bookmark in one
- bookmark should appear in both bookmark toolbars
@NejcZdovc NejcZdovc added the perf label Aug 15, 2017
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Aug 15, 2017
@NejcZdovc NejcZdovc self-assigned this Aug 15, 2017
@codecov-io
Copy link

codecov-io commented Aug 15, 2017

Codecov Report

Merging #10498 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #10498   +/-   ##
=======================================
  Coverage   54.31%   54.31%           
=======================================
  Files         245      245           
  Lines       21148    21148           
  Branches     3259     3259           
=======================================
  Hits        11486    11486           
  Misses       9662     9662
Flag Coverage Δ
#unittest 54.31% <0%> (ø) ⬆️
Impacted Files Coverage Δ
js/stores/appStore.js 12.45% <0%> (ø) ⬆️

@NejcZdovc NejcZdovc modified the milestones: 0.19.x (Beta Channel), 0.21.x (Nightly Channel) Aug 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants