Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move 'Block Phishing / Malware' option to the bottom #10816

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Move 'Block Phishing / Malware' option to the bottom #10816

merged 1 commit into from
Sep 11, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Sep 6, 2017

Closes #10813

Test Plan:

  1. Open about:preferences#shields

screenshot 2017-09-06 17 48 08

cf: on the compact bravery panel

screenshot 2017-09-06 17 48 29

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Closes #10813

Test Plan:
1. Open about:preferences#shields
@luixxiul luixxiul added feature/about-pages polish Nice to have — usually related to front-end/visual tasks. labels Sep 6, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 6, 2017
@luixxiul luixxiul self-assigned this Sep 6, 2017
@codecov-io
Copy link

codecov-io commented Sep 6, 2017

Codecov Report

Merging #10816 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #10816   +/-   ##
=======================================
  Coverage   54.17%   54.17%           
=======================================
  Files         247      247           
  Lines       21548    21548           
  Branches     3338     3338           
=======================================
  Hits        11673    11673           
  Misses       9875     9875
Flag Coverage Δ
#unittest 54.17% <0%> (ø) ⬆️
Impacted Files Coverage Δ
js/about/preferences.js 42.32% <0%> (ø) ⬆️

Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit a945dda into brave:master Sep 11, 2017
@luixxiul luixxiul deleted the polish-shield-switches-order branch September 11, 2017 08:14
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/about-pages polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants