Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix BEM naming and align elements correctly on paymentsTab.js and ledgerTable.js #10913

Merged
merged 2 commits into from
Nov 24, 2017
Merged

Fix BEM naming and align elements correctly on paymentsTab.js and ledgerTable.js #10913

merged 2 commits into from
Nov 24, 2017

Commits on Nov 21, 2017

  1. Improve ledgerTable.js 

    - Disable line wrap on 'hideExcludedSites__settingCheckbox'
- Fix BEM naming
- Make only text of anchor links clickable

Auditors:

Test Plan:
1. Run `npm run add-simulated-synopsis-visits 100`
2. Restart the browser
3. Open about:preferences#payments
4. Make sure `Show only included sites` label is not wrapped
5. Make sure only site domains are clickable
    Suguru Hirahara committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    c4826b0 View commit details
    Browse the repository at this point in the history

  2. Fix paymentsTab.js 

    - Fixes BEM naming
- Indentation
- Replace padding inside .walletBar with margin inside its elements

Closes #10912

Auditors:

Test Plan:
1. Run `npm run add-simulated-payment-history`
2. Restart the browser
3. Open about:preferences#payments
4. Make sure the layout is not broken
    Suguru Hirahara committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    a013515 View commit details
    Browse the repository at this point in the history