Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor switchControl with Aphrodite #11954

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Refactor switchControl with Aphrodite #11954

merged 1 commit into from
Dec 19, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Nov 14, 2017

Closes #11065
Closes #7321

  • Remove switchControls.less 🎉
  • Replace className with customWrapper
  • Add color properties to theme.js
  • Update data-test-id

Regression Test:

Test Plan:

  1. Open http://example.com
  2. Click the shield icon
  3. Make sure the switches work

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@codecov-io
Copy link

codecov-io commented Nov 14, 2017

Codecov Report

Merging #11954 into master will increase coverage by <.01%.
The diff coverage is 76.66%.

@@            Coverage Diff             @@
##           master   #11954      +/-   ##
==========================================
+ Coverage   54.54%   54.55%   +<.01%     
==========================================
  Files         275      275              
  Lines       26144    26150       +6     
  Branches     4196     4202       +6     
==========================================
+ Hits        14261    14265       +4     
- Misses      11883    11885       +2
Flag Coverage Δ
#unittest 54.55% <76.66%> (ø) ⬆️
Impacted Files Coverage Δ
js/about/preferences.js 45.23% <ø> (-0.12%) ⬇️
app/renderer/components/styles/global.js 100% <ø> (ø) ⬆️
app/renderer/components/styles/theme.js 100% <ø> (ø) ⬆️
app/renderer/components/common/settings.js 78.57% <ø> (ø) ⬆️
...erer/components/preferences/payment/ledgerTable.js 89.52% <0%> (ø) ⬆️
app/renderer/components/common/messageBox.js 87.75% <100%> (ø) ⬆️
app/renderer/components/preferences/paymentsTab.js 75% <100%> (ø) ⬆️
app/renderer/components/common/switchControl.js 83.67% <75%> (-1.7%) ⬇️
... and 1 more

Closes #11065
Closes #7321

- Remove switchControls.less
- Replace className with customWrapper
- Apply theme.js
- Update data-test-id

Test Plan:
1. Open http://example.com
2. Click the shield icon
3. Make sure the switches work
@cezaraugusto cezaraugusto added the 0.22.x issue first seen in 0.22.x label Dec 19, 2017
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid work ++

@cezaraugusto cezaraugusto merged commit 97ac521 into brave:master Dec 19, 2017
@cezaraugusto cezaraugusto deleted the refactor-switchControl branch December 19, 2017 22:52
@luixxiul luixxiul modified the milestones: Triage Backlog, 0.22.x (Nightly Channel) Dec 21, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants