Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Revert "Fix tabs briefly animating too wide after finishing closing some tabs" #12718

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Revert "Fix tabs briefly animating too wide after finishing closing some tabs" #12718

merged 1 commit into from
Jan 19, 2018

Conversation

petemill
Copy link
Member

@petemill petemill commented Jan 19, 2018 •
edited
Loading

Reverts #12567

There were two issues with this PR:

  1. It was not compatible with pinned tabs (with this PR they would become the same size as unpinned tabs, whenever a tab is closed and the tab bar is full)
  2. When tabs have a forced width, all css transitions on the tab are disabled.

Restoring the previous web animation api usage would be more appropriate, and fixing the referenced bug within that architecture would work.

@petemill petemill self-assigned this Jan 19, 2018
@petemill petemill added this to the 0.22.x (Nightly Channel) milestone Jan 19, 2018
@petemill petemill mentioned this pull request Jan 19, 2018
Merged
10 tasks
@cezaraugusto cezaraugusto merged commit c36885b into master Jan 19, 2018
@petemill petemill deleted the revert-12567-fix/tabs-animate-too-wide branch January 31, 2018 21:04
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@petemill petemill

Labels
regression release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@petemill @cezaraugusto @bbondy