This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Ensuring that pinned publishers are not unpinned when decimal values are entered for the pin percentage #13267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12001
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests
This is a very simple fix for the issues of decimal values unpinning a pinned publisher.
Inside the PinnedInput component, the callback for onBlur was interpreting decimal values less than 1 as falsey, causing them to be unpinned. This performs an additional check ensuring those cases are accounted for.
cc: @NejcZdovc