Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes location validation #13411

Merged
merged 1 commit into from
Mar 11, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 9, 2018

Resolves #13410

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

defined in #13410

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#13410

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.23.x (Nightly Channel) milestone Mar 9, 2018
@NejcZdovc NejcZdovc self-assigned this Mar 9, 2018
@NejcZdovc NejcZdovc requested a review from mrose17 March 9, 2018 22:13
@codecov-io
Copy link

codecov-io commented Mar 9, 2018

Codecov Report

Merging #13411 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13411      +/-   ##
==========================================
- Coverage   56.25%   56.22%   -0.04%     
==========================================
  Files         283      283              
  Lines       28353    28353              
  Branches     4674     4674              
==========================================
- Hits        15950    15941       -9     
- Misses      12403    12412       +9
Flag Coverage Δ
#unittest 56.22% <0%> (-0.04%) ⬇️
Impacted Files Coverage Δ
app/browser/api/ledger.js 59.76% <0%> (ø) ⬆️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 28.48% <0%> (-0.3%) ⬇️

Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... we had thought there were no compatibility issues with the current version. apparently, we were mistaken...

@NejcZdovc NejcZdovc merged commit 9d5977a into brave:master Mar 11, 2018
NejcZdovc added a commit that referenced this pull request Mar 11, 2018
@NejcZdovc
Copy link
Contributor Author

master 9d5977a
0.23 217baa5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants