-
Notifications
You must be signed in to change notification settings - Fork 974
add advanced webrtc IP handling preference #13713
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13713 +/- ##
==========================================
- Coverage 56.53% 56.51% -0.03%
==========================================
Files 282 283 +1
Lines 28747 28756 +9
Branches 4764 4765 +1
==========================================
- Hits 16253 16251 -2
- Misses 12494 12505 +11
|
fix #13668 Test Plan: 1. go to about:preferences#advanced 2. at the bottom, it should show a webrtc policy select menu which defaults to 'default' 3. turn on fingerprinting protection to 'block all' 4. go to https://browserleaks.com/webrtc. it should not show any IPs 5. turn off fingerprinting protection on that page. now it should show IPs 6. in about:preferences#advanced, set webrtc policy to 'default public interface only' 7. reload https://browserleaks.com/webrtc. it should only show the public IP. 8. in about:preferences#advanced, set webrtc policy to 'disable non-proxied UDP' 9. reload https://browserleaks.com/webrtc. it should show no IPs. 10. in about:preferences#advanced, set webrtc policy to 'default public and private interfaces' 11. reload https://browserleaks.com/webrtc. it should show both IPs.
@diracdeltas @bradleyrichter does it make sense to have this new setting on the |
@bsclifton i put it in advanced because probably 99.9% of users won't know what the options mean or care to change the default. it could go either way. it's more of a networking setting than a security setting. |
Clicking the Looking at the comments in the code, I'm able to map these constants (and the comments above them) to what we have in our drop-down... but I think it might be very difficult for users to do so (unless they're also programmers). I think it's good for a rev1 though- just something to keep in mind. Can definitely be improved in iterations 😄 |
@bsclifton noted. that's partly why i put it in advanced. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes work great per test plan 😄 Code changes look great and unit tests pass and accurately cover the change
add advanced webrtc IP handling preference
add advanced webrtc IP handling preference
fix #13668
Test Plan:
to 'default'
interface only'
public IP.
non-proxied UDP'
and private interfaces'
Submitter Checklist:
git rebase -i
to squash commits (if needed).Reviewer Checklist:
Tests