Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make .bookmarkFolderList sticky #2077

Merged
merged 1 commit into from
Jun 4, 2016
Merged

Make .bookmarkFolderList sticky #2077

merged 1 commit into from
Jun 4, 2016

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 4, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

close #2076
I'm not quite sure about the thing related to licencing. If there is a problem with using the library, I'll close this request.

@bbondy
Copy link
Member

bbondy commented Jun 4, 2016

The license looks ok.
I prefer not to add deps if not needed but this fixes the UX problem nicely so lets just go with it.

It can also be accomplished by making bookmarkFolderList and bookmarkList overflow-y: auto and the parent container with a height specified.

If we don't use it in other places then we can remove the dep later, if we do we can just keep it.

@bbondy bbondy merged commit fbdbdb9 into brave:master Jun 4, 2016
@luixxiul
Copy link
Contributor Author

luixxiul commented Jun 4, 2016

This can be removed when position:sticky will be implemented anyway..

@luixxiul luixxiul added this to the 0.10.3dev milestone Jun 4, 2016
@luixxiul luixxiul deleted the sticky-bookmarklist branch June 6, 2016 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make .bookmarkFolderList on about:bookmarks sticky
2 participants